-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
@gkhanna79 my change port is ok. |
👍 |
@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please |
@russellhadley @RussKeldorph Can you please take a look at JIT fix port and package changes? |
@russellhadley Should we port #6502 as well? |
That change was not in the original GH PR that is confirmed to work for PS folks? Was #6502 a fix for internal build? |
@gkhanna79 Yes, it was a fix for a build break. I believe it was specific to internal build and thus perhaps not interesting for this, but I just wanted @russellhadley to confirm. |
Regarding the ILAsm/ILDasm package versions: I don't think ILAsm/ILDasm are functionally affected by this change, but if it is necessary to update their versions because we publish this repo all-or-nothing, then this looks fine to me. @kyulee1 FYI. |
ILAsm/ILDasm packages have reference on CoreCLR package. Since CoreCLR package version is updated (and becomes prerelease), ILAsm/ILDasm need to be incremented since their (existing) stable version cannot depend upon (the new) prerelease CoreCLR version. |
@RussKeldorph #6502 isn't required the build in the open continues to work fine (there has to be errno.h coming from somewhere else in the open build). The fix was only for an internal issue. As long as the fix stays in master we should be fine. @gkhanna79 The port of my fix looks good to me. |
@weshaggard Added the servicing pre-release label. PTAL. |
LGTM |
@russellhadley Had to port #6502 as well since Arm32 comes from closed build, which required these changes to be ported, and I ran into this break. |
@dotnet-bot test Windows_NT x64 Debug Build and Test please |
…016. Corresponds to dotnet#6611 [tfs-changeset: 1621298]
…016. Corresponds to dotnet#6611 [tfs-changeset: 1621298]
…016. Corresponds to dotnet#6611 [tfs-changeset: 1621298]
Port fix for the following issues:
https://github.com/dotnet/coreclr/issues/5837
https://github.com/dotnet/coreclr/issues/6460
https://github.com/dotnet/coreclr/issues/6016
Also incremented the patch versions of affected packages (CoreCLR, JIT, ILAsm and ILDasm) so that the new version is 1.0.3.
@russellhadley @janvorli PTAL at your respective fixes that have been ported and package version changes.
CC @weshaggard @leecow @ericstj @joshfree