Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Port fixes for CoreCLR 1.0.0 RTM #6611

Merged
merged 5 commits into from
Aug 7, 2016
Merged

Conversation

gkhanna79
Copy link
Member

Port fix for the following issues:

https://github.com/dotnet/coreclr/issues/5837
https://github.com/dotnet/coreclr/issues/6460
https://github.com/dotnet/coreclr/issues/6016

Also incremented the patch versions of affected packages (CoreCLR, JIT, ILAsm and ILDasm) so that the new version is 1.0.3.

@russellhadley @janvorli PTAL at your respective fixes that have been ported and package version changes.

CC @weshaggard @leecow @ericstj @joshfree

@gkhanna79 gkhanna79 changed the title Port fixes for CoreCLR 1.0.0 RTM [DO NOT MERGE] Port fixes for CoreCLR 1.0.0 RTM Aug 4, 2016
@gkhanna79
Copy link
Member Author

CC @RussKeldorph

@janvorli
Copy link
Member

janvorli commented Aug 4, 2016

@gkhanna79 my change port is ok.

@joshfree
Copy link
Member

joshfree commented Aug 4, 2016

👍

@gkhanna79
Copy link
Member Author

@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please

@gkhanna79
Copy link
Member Author

@russellhadley @RussKeldorph Can you please take a look at JIT fix port and package changes?

@RussKeldorph
Copy link

@russellhadley Should we port #6502 as well?

@gkhanna79
Copy link
Member Author

That change was not in the original GH PR that is confirmed to work for PS folks? Was #6502 a fix for internal build?

@RussKeldorph
Copy link

@gkhanna79 Yes, it was a fix for a build break. I believe it was specific to internal build and thus perhaps not interesting for this, but I just wanted @russellhadley to confirm.

@RussKeldorph
Copy link

Regarding the ILAsm/ILDasm package versions: I don't think ILAsm/ILDasm are functionally affected by this change, but if it is necessary to update their versions because we publish this repo all-or-nothing, then this looks fine to me. @kyulee1 FYI.

@gkhanna79
Copy link
Member Author

ILAsm/ILDasm packages have reference on CoreCLR package. Since CoreCLR package version is updated (and becomes prerelease), ILAsm/ILDasm need to be incremented since their (existing) stable version cannot depend upon (the new) prerelease CoreCLR version.

@russellhadley
Copy link

@RussKeldorph #6502 isn't required the build in the open continues to work fine (there has to be errno.h coming from somewhere else in the open build). The fix was only for an internal issue. As long as the fix stays in master we should be fine.

@gkhanna79 The port of my fix looks good to me.

@weshaggard weshaggard added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 5, 2016
@gkhanna79
Copy link
Member Author

@weshaggard Added the servicing pre-release label. PTAL.

@weshaggard
Copy link
Member

LGTM

@gkhanna79
Copy link
Member Author

@russellhadley Had to port #6502 as well since Arm32 comes from closed build, which required these changes to be ported, and I ran into this break.

@gkhanna79
Copy link
Member Author

@dotnet-bot test Windows_NT x64 Debug Build and Test please

@gkhanna79 gkhanna79 changed the title [DO NOT MERGE] Port fixes for CoreCLR 1.0.0 RTM Port fixes for CoreCLR 1.0.0 RTM Aug 7, 2016
@gkhanna79 gkhanna79 merged commit 7745b40 into dotnet:release/1.0.0 Aug 7, 2016
dotnet-bot pushed a commit to dotnet-bot/coreclr that referenced this pull request Aug 7, 2016
gkhanna79 added a commit to dotnet-bot/coreclr that referenced this pull request Aug 8, 2016
gkhanna79 added a commit to dotnet-bot/coreclr that referenced this pull request Aug 8, 2016
@karelz karelz modified the milestone: 1.0.x Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
* NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants